fix: sécuriser shutdown, config par défaut et reconnexion socket

Co-authored-by: aider (openrouter/openai/gpt-5.3-codex) <aider@aider.chat>

internal/capture/capture.go

@@ -3,6 +3,7 @@ package capture
 
 import (
 	"fmt"
+	"sync"
 
 	"github.com/google/gopacket"
 	"github.com/google/gopacket/pcap"
@@ -13,6 +14,7 @@ import (
 // CaptureImpl implements the capture.Capture interface for packet capture
 type CaptureImpl struct {
 	handle *pcap.Handle
+	mu     sync.Mutex
 }
 
 // New creates a new capture instance
@@ -22,29 +24,40 @@ func New() *CaptureImpl {
 
 // Run starts network packet capture according to the configuration
 func (c *CaptureImpl) Run(cfg api.Config, out chan<- api.RawPacket) error {
-	var err error
-	c.handle, err = pcap.OpenLive(cfg.Interface, 1600, true, pcap.BlockForever)
+	handle, err := pcap.OpenLive(cfg.Interface, 1600, true, pcap.BlockForever)
 	if err != nil {
 		return fmt.Errorf("failed to open interface %s: %w", cfg.Interface, err)
 	}
-	defer c.handle.Close()
+
+	c.mu.Lock()
+	c.handle = handle
+	c.mu.Unlock()
+
+	defer func() {
+		c.mu.Lock()
+		if c.handle != nil {
+			c.handle.Close()
+			c.handle = nil
+		}
+		c.mu.Unlock()
+	}()
 
 	// Apply BPF filter if provided
 	if cfg.BPFFilter != "" {
-		err = c.handle.SetBPFFilter(cfg.BPFFilter)
+		err = handle.SetBPFFilter(cfg.BPFFilter)
 		if err != nil {
 			return fmt.Errorf("failed to set BPF filter: %w", err)
 		}
 	} else {
 		// Create default filter for monitored ports
 		defaultFilter := buildBPFForPorts(cfg.ListenPorts)
-		err = c.handle.SetBPFFilter(defaultFilter)
+		err = handle.SetBPFFilter(defaultFilter)
 		if err != nil {
 			return fmt.Errorf("failed to set default BPF filter: %w", err)
 		}
 	}
 
-	packetSource := gopacket.NewPacketSource(c.handle, c.handle.LinkType())
+	packetSource := gopacket.NewPacketSource(handle, handle.LinkType())
 
 	for packet := range packetSource.Packets() {
 		// Convert packet to RawPacket
@@ -102,8 +115,12 @@ func packetToRawPacket(packet gopacket.Packet) *api.RawPacket {
 
 // Close properly closes the capture handle
 func (c *CaptureImpl) Close() error {
+	c.mu.Lock()
+	defer c.mu.Unlock()
+
 	if c.handle != nil {
 		c.handle.Close()
+		c.handle = nil
 		return nil
 	}
 	return nil

internal/capture/capture_test.go

@@ -79,3 +79,20 @@ func TestJoinString(t *testing.T) {
 func TestCaptureIntegration(t *testing.T) {
 	t.Skip("Skipping integration test requiring network access and elevated privileges")
 }
+
+func TestClose_NoHandle_NoError(t *testing.T) {
+	c := New()
+	if err := c.Close(); err != nil {
+		t.Fatalf("Close() error = %v", err)
+	}
+}
+
+func TestClose_Idempotent_NoHandle(t *testing.T) {
+	c := New()
+	if err := c.Close(); err != nil {
+		t.Fatalf("first Close() error = %v", err)
+	}
+	if err := c.Close(); err != nil {
+		t.Fatalf("second Close() error = %v", err)
+	}
+}