fix: durcir la validation et fiabiliser flush/arrêt idempotents

Co-authored-by: aider (openrouter/openai/gpt-5.3-codex) <aider@aider.chat>

internal/adapters/inbound/unixsocket/source.go

@@ -40,6 +40,7 @@ type UnixSocketSource struct {
 	done      chan struct{}
 	wg        sync.WaitGroup
 	semaphore chan struct{} // Limit concurrent connections
+	stopOnce  sync.Once
 }
 
 // NewUnixSocketSource creates a new Unix socket source.
@@ -58,6 +59,10 @@ func (s *UnixSocketSource) Name() string {
 
 // Start begins listening on the Unix socket.
 func (s *UnixSocketSource) Start(ctx context.Context, eventChan chan<- *domain.NormalizedEvent) error {
+	if strings.TrimSpace(s.config.Path) == "" {
+		return fmt.Errorf("socket path cannot be empty")
+	}
+
 	// Remove existing socket file if present
 	if info, err := os.Stat(s.config.Path); err == nil {
 		if info.Mode()&os.ModeSocket != 0 {
@@ -78,8 +83,8 @@ func (s *UnixSocketSource) Start(ctx context.Context, eventChan chan<- *domain.N
 
 	// Set permissions - fail if we can't
 	if err := os.Chmod(s.config.Path, DefaultSocketPermissions); err != nil {
-		listener.Close()
-		os.Remove(s.config.Path)
+		_ = listener.Close()
+		_ = os.Remove(s.config.Path)
 		return fmt.Errorf("failed to set socket permissions: %w", err)
 	}
 
@@ -120,7 +125,7 @@ func (s *UnixSocketSource) acceptConnections(ctx context.Context, eventChan chan
 			// Connection accepted
 		default:
 			// Too many connections, reject
-			conn.Close()
+			_ = conn.Close()
 			continue
 		}
 
@@ -136,7 +141,7 @@ func (s *UnixSocketSource) acceptConnections(ctx context.Context, eventChan chan
 
 func (s *UnixSocketSource) readEvents(ctx context.Context, conn net.Conn, eventChan chan<- *domain.NormalizedEvent) {
 	// Set read deadline to prevent hanging
-	conn.SetReadDeadline(time.Now().Add(5 * time.Minute))
+	_ = conn.SetReadDeadline(time.Now().Add(5 * time.Minute))
 
 	scanner := bufio.NewScanner(conn)
 	// Increase buffer size limit to 1MB
@@ -167,10 +172,6 @@ func (s *UnixSocketSource) readEvents(ctx context.Context, conn net.Conn, eventC
 			return
 		}
 	}
-
-	if err := scanner.Err(); err != nil {
-		// Connection error, log but don't crash
-	}
 }
 
 func parseJSONEvent(data []byte) (*domain.NormalizedEvent, error) {
@@ -314,21 +315,26 @@ func getInt64(m map[string]any, key string) (int64, bool) {
 
 // Stop gracefully stops the source.
 func (s *UnixSocketSource) Stop() error {
-	s.mu.Lock()
-	defer s.mu.Unlock()
+	var stopErr error
 
-	close(s.done)
+	s.stopOnce.Do(func() {
+		s.mu.Lock()
+		defer s.mu.Unlock()
 
-	if s.listener != nil {
-		s.listener.Close()
-	}
+		close(s.done)
 
-	s.wg.Wait()
+		if s.listener != nil {
+			_ = s.listener.Close()
+		}
 
-	// Clean up socket file
-	if err := os.Remove(s.config.Path); err != nil && !os.IsNotExist(err) {
-		return fmt.Errorf("failed to remove socket file: %w", err)
-	}
+		s.wg.Wait()
 
-	return nil
+		// Clean up socket file
+		if err := os.Remove(s.config.Path); err != nil && !os.IsNotExist(err) {
+			stopErr = fmt.Errorf("failed to remove socket file: %w", err)
+			return
+		}
+	})
+
+	return stopErr
 }